Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Log Update" Consistency #8283

Closed
wants to merge 5 commits into from
Closed

"Log Update" Consistency #8283

wants to merge 5 commits into from

Conversation

renoseHarsh
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@renoseHarsh renoseHarsh requested a review from a team as a code owner August 9, 2024 12:45
@vercel Vercel
Copy link

vercel bot commented Aug 9, 2024

@renoseHarsh is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@netlify Netlify
Copy link

netlify bot commented Aug 9, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b45f2e9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c83aaee01e0b000882e281
😎 Deploy Preview https://deploy-preview-8283--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467 nihal467 requested a review from rithviknishad August 9, 2024 21:38
@renoseHarsh
Copy link
Contributor Author

I removed changes that could be handled by backend
and changed the routes for breadcrumbs

rithviknishad
rithviknishad requested changes Aug 10, 2024
View reviewed changes
src/Routers/routes/ConsultationRoutes.tsx Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other routes in this file that are still having the term 'daily rounds' in the paths. Let's change that too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I also change the 'daily_rounds' or is that different from 'daily-rounds'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renoseHarsh Yes refactor all instances of daily_rounds, daily-rounds, Daily Rounds

@github-actions GitHub Actions
Copy link

👋 Hi, @renoseHarsh,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added merge conflict pull requests with merge conflict and removed merge conflict pull requests with merge conflict labels Aug 14, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @renoseHarsh,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 14, 2024
@github-actions github-actions bot added the stale label Aug 22, 2024
@gigincg gigincg removed the stale label Aug 23, 2024
@gigincg
Copy link
Member

gigincg commented Aug 23, 2024

@renoseHarsh Resolved the conflicts and merged develop, Make sure that you pull, before you start working on it.

Update the PR once it's ready to be reviewed.

@github-actions github-actions bot added the stale label Aug 31, 2024
@bodhish
Copy link
Member

bodhish commented Sep 20, 2024

Closing this PR due to lack of recent progress. If you are re-opening the PR, please make sure the strings are moved to I18n

@bodhish bodhish closed this Sep 20, 2024
@renoseHarsh renoseHarsh deleted the issues/7350/log-update-consistency branch October 17, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg left review comments

@rithviknishad rithviknishad rithviknishad requested changes

Assignees
No one assigned
Labels
changes required merge conflict pull requests with merge conflict stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Log Update"- consistency in terminology
5 participants
@renoseHarsh @gigincg @bodhish @rithviknishad @nihal467